Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ipex/grant endpoint #143

Merged

Conversation

pfeairheller
Copy link
Member

@pfeairheller pfeairheller commented Dec 6, 2023

This PR fixes the ipex/grant endpoint to properly handle attachments. There was a "disagreement" between clients and KERIA about what was being sent.

This closes #141

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9dda515) 91.25% compared to head (fc55ef6) 91.23%.

Files Patch % Lines
src/keria/app/agenting.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #143      +/-   ##
===============================================
- Coverage        91.25%   91.23%   -0.02%     
===============================================
  Files               35       35              
  Lines             6012     6010       -2     
===============================================
- Hits              5486     5483       -3     
- Misses             526      527       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lenkan
Copy link
Collaborator

lenkan commented Dec 6, 2023

Great! I had the same issue.

@pfeairheller pfeairheller merged commit f31296a into WebOfTrust:development Dec 6, 2023
5 checks passed
@pfeairheller pfeairheller deleted the feat-grant-as-present branch December 6, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a way to get signatures of an already issued credential
2 participants