refactor sizage #55
Merged
refactor sizage #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #55 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 8 8
Lines 965 965
=======================================
Hits 947 947
Misses 18 18
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
m00sey
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Sizage is not uniform and is actually table specific. In the upcoming
IndexerPR (#49) we will have a structural conflict.Changes
Creates
CodexspecificSizages.Testing
This was only a change in location, no logic changed. Current tests assert that nothing we know could break has broken.