Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRYSTALS Dilithium #149

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

jasoncolburne
Copy link
Collaborator

@jasoncolburne jasoncolburne commented Aug 13, 2023

https://csrc.nist.gov/Projects/post-quantum-cryptography/selected-algorithms-2022
https://blog.cloudflare.com/nist-post-quantum-surprise/
https://pq-crystals.org/dilithium/

We recommend using the Dilithium3 parameter set, which—according to a very conservative analysis—achieves more than 128 bits of security against all known classical and quantum attacks.

Seems to work. Here's a branch/PR of some test code that exercises this stuff:
jasoncolburne/keri-acdc#1

@codecov
Copy link

codecov bot commented Aug 13, 2023

Codecov Report

Merging #149 (9ae769b) into main (2b2a39f) will increase coverage by 0.15%.
The diff coverage is 100.00%.

❗ Current head 9ae769b differs from pull request most recent head 8d1ce42. Consider uploading reports for the commit 8d1ce42 to get more accurate results

@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
+ Coverage   95.35%   95.51%   +0.15%     
==========================================
  Files          32       32              
  Lines        3036     3121      +85     
==========================================
+ Hits         2895     2981      +86     
+ Misses        141      140       -1     
Files Changed Coverage Δ
src/core/cigar.rs 97.36% <ø> (ø)
src/core/matter/mod.rs 87.95% <ø> (ø)
src/core/prefixer.rs 98.80% <ø> (ø)
src/core/siger.rs 97.61% <ø> (ø)
src/core/verfer.rs 100.00% <ø> (ø)
src/core/indexer/tables.rs 100.00% <100.00%> (ø)
src/core/matter/tables.rs 100.00% <100.00%> (ø)
src/core/signer.rs 94.44% <100.00%> (+1.04%) ⬆️
src/crypto/sign.rs 97.54% <100.00%> (+1.48%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jasoncolburne jasoncolburne changed the title try CRYSTALS Dilithium CRYSTALS Dilithium Aug 14, 2023
@qui-jason
Copy link

I finally understand why codecov didn't update for the past two pushes - they were changes to the README and didn't touch code.

@m00sey
Copy link
Member

m00sey commented Aug 28, 2023

Happy to pull this in if its ready for review

@jasoncolburne
Copy link
Collaborator Author

I think we discussed in KERI dev a couple weeks ago that we wouldn't merge yet as it adds new codes etc. we probably need alignment in keripy and there is also the falcon branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants