Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write ADR for converting tests from jest to native #21

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion adrs/001-use-adrs.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## Status

Approved
Implemented

## Context

Expand Down
2 changes: 1 addition & 1 deletion adrs/002-copy-signify-ts-as-initial-commit.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## Status

Approved
Implemented

## Context

Expand Down
21 changes: 21 additions & 0 deletions adrs/003-convert-jest-tests-to-native-runner.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# [003] - Convert Jest tests to native Node.js test runner

## Status

Proposed

## Context

Node.js has had a built-in test runner since v18. The docs are found [here](https://nodejs.org/api/test.html). Jest is a fairly heavy dependency and it has had some maintenance issues in recent years.

## Decision

To remove dependencies where possible and to adjust to convention: Rewrite existing tests to run with the native runner and eliminate Jest.

## Consequences

The native test runner does require the specification of a module loader to run typescript files directly, but it is [straightforward to fix](https://glebbahmutov.com/blog/trying-node-test-runner/#typescript).

## Other Options Considered

Sticking with Jest.