-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement EXT_provoking_vertex draft extension #3701
Conversation
EWS run on previous version of this PR (hash 597c1a6) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks good. Let's land only after we have the test in the tree.
Since it's a draft extension, the test may have no effect because of https://bugs.webkit.org/show_bug.cgi?id=242053. |
EWS run on previous version of this PR (hash 0d09020)
|
EWS run on current version of this PR (hash 76f4d4f) |
https://bugs.webkit.org/show_bug.cgi?id=244363 Reviewed by Kimmo Kinnunen. * LayoutTests/TestExpectations: * LayoutTests/platform/gtk/TestExpectations: * LayoutTests/platform/ios-simulator/webgl/webgl-draft-extensions-flag-default-expected.txt: * LayoutTests/platform/ios-simulator/webgl/webgl-draft-extensions-flag-off-expected.txt: * LayoutTests/platform/ios-simulator/webgl/webgl-draft-extensions-flag-on-expected.txt: * LayoutTests/webgl/resources/webgl-draft-extensions-flag.js: * LayoutTests/webgl/webgl-draft-extensions-flag-default-expected.txt: * LayoutTests/webgl/webgl-draft-extensions-flag-off-expected.txt: * LayoutTests/webgl/webgl-draft-extensions-flag-on-expected.txt: * Source/WebCore/CMakeLists.txt: * Source/WebCore/DerivedSources-input.xcfilelist: * Source/WebCore/DerivedSources-output.xcfilelist: * Source/WebCore/DerivedSources.make: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/bindings/js/JSDOMConvertWebGL.cpp: (WebCore::convertToJSValue): * Source/WebCore/html/canvas/EXTProvokingVertex.cpp: Added. (WebCore::EXTProvokingVertex::EXTProvokingVertex): (WebCore::EXTProvokingVertex::getName const): (WebCore::EXTProvokingVertex::supported): (WebCore::EXTProvokingVertex::provokingVertexEXT): * Source/WebCore/html/canvas/EXTProvokingVertex.h: Added. * Source/WebCore/html/canvas/EXTProvokingVertex.idl: Added. * Source/WebCore/html/canvas/WebGL2RenderingContext.cpp: (WebCore::WebGL2RenderingContext::getExtension): (WebCore::WebGL2RenderingContext::getSupportedExtensions): (WebCore::WebGL2RenderingContext::getParameter): * Source/WebCore/html/canvas/WebGLExtension.h: * Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::extensionIsEnabled): (WebCore::WebGLRenderingContextBase::loseExtensions): * Source/WebCore/html/canvas/WebGLRenderingContextBase.h: * Source/WebCore/platform/graphics/GraphicsContextGL.h: * Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp: (WebCore::GraphicsContextGLANGLE::provokingVertexANGLE): * Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h: * Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.messages.in: * Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLFunctionsGenerated.h: (provokingVertexANGLE): * Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h: * Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp: (WebKit::RemoteGraphicsContextGLProxy::provokingVertexANGLE): Canonical link: https://commits.webkit.org/255261@main
Committed 255261@main (862fe9c): https://commits.webkit.org/255261@main Reviewed commits have been landed. Closing PR #3701 and removing active labels. |
862fe9c
76f4d4f
🧪 ios-wk2🧪 api-mac