Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

text-align: match-parent on root handles direction incorrectly #1208

Merged
merged 0 commits into from
Jun 2, 2022
Merged

text-align: match-parent on root handles direction incorrectly #1208

merged 0 commits into from
Jun 2, 2022

Conversation

nt1m
Copy link
Member

@nt1m nt1m commented Jun 1, 2022 •
edited by webkit-early-warning-system
Loading

faf2d5c

text-align: match-parent on root handles direction incorrectly
https://bugs.webkit.org/show_bug.cgi?id=241164

Reviewed by Myles C. Maxfield.

The spec says the initial containing block's direction should be used when the element has no parent.

Regarding the computed value, Chrome & Firefox computes to `start` for this case.
This may change in w3c/csswg-drafts#6542 to `left`/`right`.

Test: imported/w3c/web-platform-tests/css/css-text/text-align/text-align-match-parent-root-rtl.html

* LayoutTests/TestExpectations:
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertTextAlign):

Canonical link: https://commits.webkit.org/251211@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@nt1m nt1m self-assigned this Jun 1, 2022
@nt1m nt1m added CSS Cascading Style Sheets implementation Safari Technology Preview labels Jun 1, 2022
@nt1m nt1m requested a review from anttijk June 1, 2022 12:53
@nt1m nt1m force-pushed the text-align-rtl branch 3 times, most recently from c8b36ef to 8c837d7 Compare June 1, 2022 13:19
@nt1m nt1m requested review from smfr and litherum June 1, 2022 15:34
@litherum
Copy link
Contributor

litherum commented Jun 2, 2022

🆗

@nt1m nt1m added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 2, 2022
@webkit-early-warning-system webkit-early-warning-system merged commit faf2d5c into WebKit:main Jun 2, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r295120 (251211@main): https://commits.webkit.org/251211@main

Reviewed commits have been landed. Closing PR #1208 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 2, 2022
@nt1m nt1m deleted the text-align-rtl branch June 2, 2022 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@litherum litherum litherum approved these changes

@anttijk anttijk Awaiting requested review from anttijk

@smfr smfr Awaiting requested review from smfr

Assignees

@nt1m nt1m

Labels
CSS Cascading Style Sheets implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nt1m @litherum @webkit-early-warning-system