#36 Retain existing CSS classes on buttons on size change #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
WDSBT-63
#36
Description
Updated the way the class name for the custom button size control is handled.
Took inspiration from how Gutenberg handles this for block styles with
replaceActiveStyle()
, but the gist is that it will create a token list from the existing class names on the block and then removes or adds a class name when appropriate and returns the new value.So, the current class name will be removed from the list if one exists and a new class name will be added if a size was selected.
Mobile & Desktop Screenshots/Recordings
Added to documentation?
Added tests?
Testing Instructions
Confirm that you can change the style and size on a button block independently without wiping out one or the other.
Reviewer's Testing Checklist
As a reviewer, please verify that the relevant testing criteria are fulfilled and confirmed before approving this Pull Request.
npm run a11y
.[optional] Additional Reviewer Notes or Considerations?