Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#36 Retain existing CSS classes on buttons on size change #45

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

Cheffheid
Copy link
Contributor

@Cheffheid Cheffheid commented Oct 31, 2024

Closes

WDSBT-63
#36

Description

Updated the way the class name for the custom button size control is handled.

Took inspiration from how Gutenberg handles this for block styles with replaceActiveStyle(), but the gist is that it will create a token list from the existing class names on the block and then removes or adds a class name when appropriate and returns the new value.

So, the current class name will be removed from the list if one exists and a new class name will be added if a size was selected.

Mobile & Desktop Screenshots/Recordings

fixed-buttons

Added to documentation?

  • 📜 README.md
  • 📓 Confluence
  • 🙅 No documentation needed

Added tests?

  • 👍 Yes
  • 🙅 No, because they aren't needed
  • 🙋 No, because I need help

Testing Instructions

Confirm that you can change the style and size on a button block independently without wiping out one or the other.


Reviewer's Testing Checklist

As a reviewer, please verify that the relevant testing criteria are fulfilled and confirmed before approving this Pull Request.

  • Visual Regression Testing: Ensure that existing functionality is not negatively impacted by the changes.
  • Cross-Browser Compatibility: Test on major browsers (Chrome, Firefox, Safari) to ensure compatibility.
  • Mobile Responsiveness: Confirm that the changes are responsive and functional on various mobile devices.
  • Theme Compatibility: Ensure that the changes do not adversely affect the site's theme and styling.
  • Linting: Check that the code passes all linting checks (PHPCS, ESLint, SassLint). Check if PR passes code quality check.
  • Accessibility Testing: Validate that the changes comply with accessibility standards. Run npm run a11y.
  • Security Best Practices: Ensure that the code follows WordPress security best practices. Check if PR passes security check.
  • Documentation: Ensure that any new features or changes are appropriately documented in the README.md or Confluence.
  • Post-Deployment Tasks: Check if there are any tasks that need to be performed after deployment.

[optional] Additional Reviewer Notes or Considerations?

@Cheffheid Cheffheid requested a review from khleomix as a code owner October 31, 2024 19:51
Copy link
Contributor

@thatmitchcanter thatmitchcanter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go. Thanks!

@thatmitchcanter thatmitchcanter merged commit 3847cda into main Nov 6, 2024
3 of 4 checks passed
@thatmitchcanter thatmitchcanter deleted the fix/WDSBT-63-retain-existing-button-style branch November 6, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants