Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix / style.css path in custom webpack config #31

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

itsamoreh
Copy link
Contributor

Closes

N/A

Link to test

N/A - Please try building the theme and verify that there are no 404 errors on the frontend.

Description

Hotfix to change the path to index.scss in the webpack config. This fixes a style.css 404 error.

Mobile & Desktop Screenshots/Recordings

2024-07-08-11 33 29

Testing Instructions

  1. Pull this branch
  2. Build the theme npm run build
  3. Verify that /build/css/style.css exists in the build folder, and that there is no 404 error on the frontend

Reviewer's Testing Checklist

As a reviewer, please verify that the relevant testing criteria are fulfilled and confirmed before approving this Pull Request.

  • Visual Regression Testing: Ensure that existing functionality is not negatively impacted by the changes.
  • Cross-Browser Compatibility: Test on major browsers (Chrome, Firefox, Safari) to ensure compatibility.
  • Mobile Responsiveness: Confirm that the changes are responsive and functional on various mobile devices.
  • Theme Compatibility: Ensure that the changes do not adversely affect the site's theme and styling.
  • Linting: Check that the code passes all linting checks (PHPCS, ESLint, SassLint). Check if PR passes code quality check.
  • Accessibility Testing: Validate that the changes comply with accessibility standards. Run npm run a11y.
  • Security Best Practices: Ensure that the code follows WordPress security best practices. Check if PR passes security check.
  • Documentation: Ensure that any new features or changes are appropriately documented in the README.md or Confluence.
  • Post-Deployment Tasks: Check if there are any tasks that need to be performed after deployment.

[optional] Additional Reviewer Notes or Considerations?

@itsamoreh itsamoreh requested a review from khleomix as a code owner July 8, 2024 15:35
Copy link
Contributor

@khleomix khleomix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @itsamoreh!

@khleomix khleomix merged commit 8190b60 into main Jul 8, 2024
7 checks passed
@khleomix khleomix deleted the hotfix/style-css-404 branch July 8, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants