Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/WDSUS-45 WDS Cleanup #1072

Merged
merged 19 commits into from
Sep 28, 2023
Merged

Feature/WDSUS-45 WDS Cleanup #1072

merged 19 commits into from
Sep 28, 2023

Conversation

khleomix
Copy link
Contributor

Closes

WDSUS-45

What type of PR is this? (put an x to all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Link to test

Test locally for now.

Description

  • Adds in header and footer patterns and template parts
  • Function cleanups
  • Remove/fix theme json core styles
  • Adjust contentSize for layouts
  • Fix mobile issues
  • Fix linting errors

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

image

image

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 Confluence
  • 🙅 no documentation needed

Others

  • 🦮 Is this issue accessible? (Section 508/WCAG 2.0AA)
  • 🙌 Does this issue pass all the linting? (PHPCS, ESLint, SassLint)

[optional] Are there any post-deployment tasks we need to perform?

@khleomix
WDSUS-45 - Update lock files
77435d5
@khleomix
WDSUS-45 - Remove footer from critical css
71a1122
@khleomix
WDSUS_45 - Add patterns, parts, templates folders
1d59c2e
@khleomix
WDSUS-45 - Add core navigation style
1ccaac6
@khleomix
WDSUS-45 - Remove unused styles and functions
5527bce
@khleomix
WDSUS-45 - Add page default template
21a0f64
@khleomix
WDSUS-45 - Leave blank to enable site editor
7bdbbc8
@khleomix
WDSUS-45 - Remove footer from critical css
4f8546e
@khleomix
WDSUS-45 - Add footer and header blocks to use for the header and foo…
f5d3aa2 
…ter php templates
@khleomix
WDSUS-45 - Update templates to make use of do_blocks()
327da4e
@khleomix
WDSUS-45 - Remove wd_s, already present in namespace
6344fdc
@khleomix
WDSUS-45 - Remove wd_s, already present in namespace
9d78164
@khleomix
WDSUS-45 - Update lock files and lefthook
9792ca6
@khleomix
WDSUS-45 - Add default home and front page templates
dd0a6ae
@khleomix
WDSUS-45 - Fix post taxonomies function
5d080cf
@khleomix
WDSUS-45 - fix mobile navigation layout issue
b936f78
@khleomix
WDSUS-45 - Fix mobile no padding issue #1061
517484f
@khleomix
WDSUS-45 - Update themejson styles
652bd9f
@khleomix
WDSUS-45 - Remove extra functions in favor of core header and footer …
de45f2e 
…area functions
@khleomix khleomix self-assigned this Sep 22, 2023
@khleomix khleomix requested a review from itsamoreh September 22, 2023 20:53
thatmitchcanter
thatmitchcanter approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@thatmitchcanter thatmitchcanter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and everything seems to be in order. Nice work, y'all. Approved!

@thatmitchcanter thatmitchcanter merged commit 2cc09c0 into release/WDSUS-2-4.0-Theme-Revamp Sep 28, 2023
@thatmitchcanter thatmitchcanter deleted the feature/WDSUS-45-wd_s-cleanup branch September 28, 2023 14:54
@schlotterer schlotterer mentioned this pull request Sep 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatmitchcanter thatmitchcanter thatmitchcanter approved these changes

@johnheimkes johnheimkes Awaiting requested review from johnheimkes

@itsamoreh itsamoreh Awaiting requested review from itsamoreh

Assignees

@khleomix khleomix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khleomix @thatmitchcanter