Skip to content
This repository has been archived by the owner on Feb 27, 2024. It is now read-only.

Fix/676 gf file upload issue #678

Draft
wants to merge 10 commits into
base: canary
Choose a base branch
from
Draft

Conversation

ravewebdev
Copy link
Contributor

@ravewebdev ravewebdev commented Sep 21, 2021

Closes #676

Description

  • Addresses bug in wds-headless-blocks causing block rendering to break. Splits hex color handling into separate filters for attrs and edit override.
  • Bumps requirement for WP GraphQL Gravity Forms to ^0.6. Note: 0.7.0 introduces breaking changes, which we will need to integrate separately at a later date due to the complexity involved.
  • Re-applies changes from Fixing 500 error on GF Form Submission #606 that were lost in the switch to canary.

Screenshot

Screen Shot 2021-09-21 at 3 45 49 PM

Verification

  1. gh pr checkout 676
  2. Ensure local WP install is running WP GraphQL Gravity Forms 0.6.x
  3. npm run build && npm run start
  4. http://localhost:3000/contact
  5. submit form with an image upload

@vercel
Copy link

vercel bot commented Sep 21, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webdevstudios/nextjs-wordpress-starter/Cmiz8exmyTLCk13k25WqgUJgUUQq
✅ Preview: https://nextjs-wordpress-starter-git-fix-676-gf-fi-ba3eaf-webdevstudios.vercel.app

@justlevine
Copy link

@ravewebdev wasn't entirely sure where to leave this, but I'd hold off a few weeks before migrating to v0.7+

The next release is a major rewrite of the plugin but we expect it to be the last major breaking change on the path to v1.0 (e.g. not bugfixing an Int to a Float, or replacing a string with an enum.)

With it should come a significantly simpler way to handle custom fields, better query syntaxes, and more robust/performant ways to query/mutate/paginate and otherwise handle data.

@ravewebdev
Copy link
Contributor Author

@justlevine do you have an estimated release date for this next release?

@justlevine
Copy link

@ravewebdev at the current pace, I'd say ~3 weeks.

@justlevine
Copy link

@ravewebdev https://github.com/harness-software/wp-graphql-gravity-forms/tree/v0.10.0

There's tons of breaking changes, but there shouldnt be any more major breaks before v1.0. Feel free to hmu on the WPGraphQL slack if you need any help with the migration.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GravityForms File Upload error 500
3 participants