Skip to content
This repository has been archived by the owner on Feb 27, 2024. It is now read-only.

feature/410-expand-block-attrs #472

Merged
merged 16 commits into from
Jun 1, 2021
Merged

Conversation

ravewebdev
Copy link
Contributor

@ravewebdev ravewebdev commented May 28, 2021

References #410
Closes #470

Description

Expands WP core block attribute support:

  • Code: adds support for multiple class names to be passed (first is used as language, rest are passed as className)
  • Media & Text: adds support for class and anchor
  • Columns: adds support for class and anchor on outer Columns and inner Column
  • Cover: adds support for class and anchor
  • Separator: adds support for anchor

Screenshot

Screen Shot 2021-05-28 at 2 51 40 PM

Screen Shot 2021-05-28 at 3 21 55 PM

Screen Shot 2021-05-28 at 3 23 30 PM

Screen Shot 2021-05-28 at 3 27 34 PM

Screen Shot 2021-05-28 at 3 29 30 PM

Verification

https://nextjs-wordpress-starter-clmxb3scz-webdevstudios.vercel.app/blog/410-anchor-classname-testing

  • ensure all blocks above display anchor/id

@vercel
Copy link

vercel bot commented May 28, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webdevstudios/nextjs-wordpress-starter/BLW5nnz6EXVarMeYYqmx5u3TMH7p
✅ Preview: https://nextjs-wordpre-git-feature-410-expand-block-attrs-webdev-ede670.vercel.app

@ravewebdev ravewebdev changed the title Allow for multiple classnames to pass lang and class feature/410-expand-block-attrs May 28, 2021
@gregrickaby gregrickaby marked this pull request as ready for review June 1, 2021 12:49
@gregrickaby gregrickaby self-requested a review as a code owner June 1, 2021 12:49
@gregrickaby gregrickaby merged commit 31859bf into main Jun 1, 2021
@gregrickaby gregrickaby deleted the feature/410-expand-block-attrs branch June 1, 2021 13:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

className doesnt come through on core blocks
2 participants