Skip to content
This repository has been archived by the owner on Feb 27, 2024. It is now read-only.

Feature/383 todos acfblockmediatext #384

Merged
merged 10 commits into from
Apr 27, 2021

Conversation

ravewebdev
Copy link
Contributor

@ravewebdev ravewebdev commented Apr 23, 2021

Closes #378

Description

Adds bool nextImageFill prop to DisplayImage component to allow for absolute positioning of auto-inserted wrapper div by next/image.
Adds altText field to media attr query.
Updates ACF Media Text block to query media item data and display with DisplayImage component.

Screenshot

Screen Shot 2021-04-23 at 3 09 07 PM

Verification

https://nextjs-wordpress-starter-kvsod5hk6-webdevstudios.vercel.app/blog/acf-media-text-block-test

@vercel
Copy link

vercel bot commented Apr 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webdevstudios/nextjs-wordpress-starter/DZH5AMGSvdKucuZa9JMJ4VtAyyPA
✅ Preview: https://nextjs-wordpre-git-feature-383-todos-acfblockmediatext-w-42b9df.vercel.app

@ravewebdev ravewebdev requested a review from itsamoreh April 23, 2021 21:10
@ravewebdev ravewebdev marked this pull request as ready for review April 23, 2021 21:11
@ravewebdev ravewebdev requested a review from gregrickaby as a code owner April 23, 2021 21:11
Copy link
Contributor

@itsamoreh itsamoreh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ravewebdev ravewebdev merged commit 178babd into main Apr 27, 2021
@ravewebdev ravewebdev deleted the feature/383-todos-acfblockmediatext branch April 27, 2021 18:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add handling for image in ACF Media Text block
2 participants