Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify adding an EventListener also opens MIDIInput ports #275

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Specify adding an EventListener also opens MIDIInput ports #275

merged 1 commit into from
Jan 7, 2025
+3 −2

Conversation

mjwilson-google
Copy link
Contributor

This is to fix #225

@mjwilson-google
Copy link
Contributor Author

Paul, your initial issue report talked about MIDIOuptut but I think the change should be about MIDIInput instead. Could you please review this, and help clarify if I've misunderstood?

padenot
padenot approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@padenot padenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, my mistake, this looks good, thanks!

@mjwilson-google mjwilson-google merged commit 6e85e43 into WebAudio:gh-pages Jan 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padenot padenot padenot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Event Handlers vs. Event Listener and implicit call to open()
2 participants
@mjwilson-google @padenot