Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C API: u8 in Rust corresponds to unsigned char* in C #179

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

C API: u8 in Rust corresponds to unsigned char* in C #179

wants to merge 1 commit into from

Conversation

dannywillems
Copy link

@dannywillems dannywillems mentioned this pull request Feb 23, 2023
Closed
@rossberg
Copy link
Member

Wouldn't it be more appropriate to fix the typedef for byte_t instead?

@dannywillems
Copy link
Author

I thought about it. byte_t is used in different places, and I didn't know if it would impact a lot of the codebase/users.

If you confirm it is fine, I agree with changing.

@syrusakbary
Copy link
Contributor

@rossberg thoughts on this 👆?

@rossberg
Copy link
Member

Yes, confirmed. Thanks. :)

@syrusakbary
Copy link
Contributor

@dannywillems should we update then the byte_t typedef so this PR can be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dannywillems @rossberg @syrusakbary