Add WASI_API macro to each API entry point #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the build system do think such as:
-DWASM_API=__attribute__((visibility("default")))
An alternative to this would be do something more explicit and
include the macros in the source like in binaryen:
#if defined(_MSC_VER) && !defined(BUILD_STATIC_LIBRARY)
efine BINARYEN_API __declspec(dllexport)
#else
Or we could try to do it without tagging each entry point using:
#pragma GCC visibility push
#pragma GCC visibility pop
But these is less portable. For example I'm not sure if msvc supports
this kind of things.
แก้ไข |
|
Could you please provide a proper PR description? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
แก้ไข