wasi-sdk-pthread.cmake: add --import-memory #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shall we also add |
i don't think there is a good single value for |
|
i marked this a draft because this needs llvm >=16. |
|
I am also wondering if we should rename this file |
toyobayashi
added a commit
to toyobayashi/emnapi
that referenced
this pull request
Feb 16, 2023
i don't think so as what this provides is pthread. |
|
this is ready as we now ship llvm 16. |
abrown
approved these changes
Apr 6, 2023
wasi-sdk-pthread.cmake
Outdated
| @@ -9,6 +9,11 @@ set(CMAKE_SYSTEM_PROCESSOR wasm32) | |||
| set(triple wasm32-wasi-threads) | |||
| set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -pthread") | |||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -pthread") | |||
| # wasi-threads requries --import-memory. | |||
There was a problem hiding this comment.
Suggested change
| # wasi-threads requries --import-memory. | |
| # wasi-threads requires --import-memory. |
yamt
force-pushed
the
wasi-threads-import-memory
branch
from
4bd8f7e to
99a0681
Compare
yamt
added a commit
to yamt/wasi-testsuite
that referenced
this pull request
Aug 10, 2024
wasi requires the memory exported as "memory". certain runtimes actually requires it. (eg. wasmtime) cf. WebAssembly/wasi-sdk#297 also, bump the wasi-sdk version because this doesn't work with an old wasm-ld.
loganek
pushed a commit
to WebAssembly/wasi-testsuite
that referenced
this pull request
Aug 12, 2024
wasi requires the memory exported as "memory". certain runtimes actually requires it. (eg. wasmtime) cf. WebAssembly/wasi-sdk#297 also, bump the wasi-sdk version because this doesn't work with an old wasm-ld.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.