Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

threads: change wasm32-wasi-pthread to wasm32-wasi-threads #381

Merged
merged 2 commits into from
Jan 13, 2023
Merged

threads: change wasm32-wasi-pthread to wasm32-wasi-threads #381

merged 2 commits into from
Jan 13, 2023

Commits on Jan 13, 2023

  1. Change wasm32-wasi-pthread to wasm32-wasi-threads 

    After some thought, I think that we should rename the `THREAD_MODEL=posix` build to avoid confusion. Why? Though in this project the use of this target does involve pthreads, it will not be so in other standard libraries or languages (see, e.g., rust-lang/compiler-team#574). I think it would be preferable to emphasize the "threads" Wasm-level proposal and the "wasi-threads" proposal rather than the specific details of which threading API is being exposed.
    @abrown
    abrown committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    b03fe62 View commit details
    Browse the repository at this point in the history

  2. fix: rename the expected output directory as well

    @abrown
    abrown committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    3124868 View commit details
    Browse the repository at this point in the history