Import jsapi tests from WPT. #883

Ms2ger · 2018-10-02T13:06:35Z

No description provided.

binji · 2018-10-04T18:54:04Z

test/js-api/bad-imports.js

+      builder => {
+        builder.addImport("module", "fn", kSig_v_v);
+      },
+      value);


should be imports, right?

binji · 2018-10-05T21:47:00Z

test/js-api/module/customSections.any.js

+  const bytes2 = [74, 83, 65, 80, 73];
+
+  const binary = new Binary;
+  binary.emit_section(kUnknownSectionCode, section => {


Probably should rename to kCustomSectionCode

I'd like to bring the module builder code in sync with the other copy in this repo, but I'd rather not block this PR on that.

binji · 2018-10-05T22:23:12Z

test/js-api/module/customSections.any.js

+  assert_sections(WebAssembly.Module.customSections(module, "na\uFFFDme"), [
+    bytes,
+  ]);
+  assert_sections(WebAssembly.Module.customSections(module, "na\uDC01me"), [


This is a bit surprising to me, since the customSections algorithm says it uses UTF-8 decode without BOM or fail, which doesn't seem to convert the 0xdc01 to a 0xfffd (though I see that elsewhere in the spec). Does the replacement happen somewhere else?

customSections takes a USVString, which introduces the replacement character; the "UTF-8 decode without BOM or fail" algorithm is only applied to the bytes in the module, which contain an explicit U+FFFD from the emit_string call.

Thanks, that makes sense.

binji · 2018-10-05T22:39:20Z

test/js-api/wasm-constants.js

+let kElementSectionCode = 9;  // Elements section
+let kCodeSectionCode = 10;      // Function code
+let kDataSectionCode = 11;     // Data segments
+let kNameSectionCode = 12;     // Name section (encoded as string)


Remove (unused)

binji · 2018-10-05T22:40:44Z

test/js-api/wasm-constants.js

+  "invalid index into function table"
+];
+
+function assertTraps(trap, code) {


remove (unused?)

binji · 2018-10-05T22:40:52Z

test/js-api/wasm-constants.js

+let kTrapFuncSigMismatch      = 7;
+let kTrapInvalidIndex         = 8;
+
+let kTrapMsgs = [


Not specified, right?

littledan · 2018-10-09T20:58:00Z

Before landing this patch, please verify that it works with the procedures used in at least one browser Wasm implementation to regularly update from this repository (last time I checked, all four take the tests from here, in a manual pull process).

Ms2ger · 2018-10-10T08:28:14Z

(There will be no need to import from here into SpiderMonkey, as these tests already run there.)

littledan · 2018-10-10T09:25:54Z

@Ms2ger maybe you could try with another one? It test it out with SpiderMonkey's old procedure?

binji · 2018-10-10T15:36:14Z

cc @titzer for trying these tests on v8

Add documentation and use the correct argument in one set of tests.

binji · 2018-10-12T23:30:13Z

I started running these in v8. It seems this uses a number of new functions from the https://web-platform-tests.org/writing-tests/testharness-api.html, so we should probably add these to README.md:

assert_throws
format_value
assert_class_string
setup
promise_rejects

See the WIP changes here: https://chromium-review.googlesource.com/c/v8/v8/+/1277724

Ms2ger · 2018-10-15T08:51:15Z

Thanks! Please let me know if you have any more comments; I'll update the readme some time this week.

binji · 2018-10-16T21:48:00Z

OK, I have these tests running (but not yet all passing) in v8. Since they also run in spidermonkey, I think this is good to land. We can address other concerns in future CLs.

FYI @kmiller68 @Cellule

These changes were necessary to run with the new style of jsapi tests introduced in WebAssembly/spec#883. Change-Id: I4629dd48d595ed97ed0607dec9e7d9808c706a7e Reviewed-on: https://chromium-review.googlesource.com/c/1277724 Commit-Queue: Ben Smith <[email protected]> Reviewed-by: Andreas Haas <[email protected]> Reviewed-by: Michael Achenbach <[email protected]> Reviewed-by: Mathias Bynens <[email protected]> Cr-Commit-Position: refs/heads/master@{#56745}

This reverts commit a12203c. Reason for revert: Breaks isolate_tests https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20builder/36777 Original change's description: > [wasm] Add a new wasm-js testsuite to run js-api tests > > These changes were necessary to run with the new style of jsapi tests > introduced in WebAssembly/spec#883. > > Change-Id: I4629dd48d595ed97ed0607dec9e7d9808c706a7e > Reviewed-on: https://chromium-review.googlesource.com/c/1277724 > Commit-Queue: Ben Smith <[email protected]> > Reviewed-by: Andreas Haas <[email protected]> > Reviewed-by: Michael Achenbach <[email protected]> > Reviewed-by: Mathias Bynens <[email protected]> > Cr-Commit-Position: refs/heads/master@{#56745} [email protected],[email protected],[email protected],[email protected],[email protected],[email protected] Change-Id: I2edd0ca94cb5990322571879c81671fa835f3ecd No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1286526 Reviewed-by: Bill Budge <[email protected]> Commit-Queue: Bill Budge <[email protected]> Cr-Commit-Position: refs/heads/master@{#56746}

This is a reland of a12203c Original change's description: > [wasm] Add a new wasm-js testsuite to run js-api tests > > These changes were necessary to run with the new style of jsapi tests > introduced in WebAssembly/spec#883. > > Change-Id: I4629dd48d595ed97ed0607dec9e7d9808c706a7e > Reviewed-on: https://chromium-review.googlesource.com/c/1277724 > Commit-Queue: Ben Smith <[email protected]> > Reviewed-by: Andreas Haas <[email protected]> > Reviewed-by: Michael Achenbach <[email protected]> > Reviewed-by: Mathias Bynens <[email protected]> > Cr-Commit-Position: refs/heads/master@{#56745} Change-Id: I25fcd95bfc1aee1d21da390359423e5dfed112a4 Reviewed-on: https://chromium-review.googlesource.com/c/1286952 Commit-Queue: Ben Smith <[email protected]> Reviewed-by: Ben Smith <[email protected]> Reviewed-by: Michael Achenbach <[email protected]> Cr-Commit-Position: refs/heads/master@{#56791}

Ms2ger force-pushed the import-jsapi-tests branch from 199962e to 6187f68 Compare October 2, 2018 13:13

binji reviewed Oct 5, 2018

View reviewed changes

Ms2ger and others added 4 commits October 12, 2018 12:54

Import jsapi tests from WPT.

7d48f11

Add LICENSE file to ensure compatibility with WPT.

3079190

Improve bad-imports.js.

fc7f006

Add documentation and use the correct argument in one set of tests.

Support subdirectories of test/js-api in build.py.

2baa839

Ms2ger force-pushed the import-jsapi-tests branch from 46e2e05 to 2baa839 Compare October 12, 2018 10:54

binji mentioned this pull request Oct 15, 2018

Make jsapi.js test strict-compliant #891

Closed

binji merged commit cf67a47 into WebAssembly:master Oct 16, 2018

Ms2ger deleted the import-jsapi-tests branch October 17, 2018 08:16

Honry added a commit to Honry/spec that referenced this pull request Oct 24, 2018

[test] Fix building error introduced in WebAssembly#883

27634f6

binji pushed a commit that referenced this pull request Oct 24, 2018

[test] Fix building error introduced in #883 (#900)

b0e7838

binji mentioned this pull request Nov 27, 2018

[jsapi] inconsistent utf-8 decoding #915

Closed

Ms2ger mentioned this pull request Dec 18, 2018

[test] Split up jsapi.js #596

Closed

Ms2ger mentioned this pull request Apr 11, 2019

Synchronize wasm test changes from the spec repo. web-platform-tests/wpt#16314

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Import jsapi tests from WPT. #883

Import jsapi tests from WPT. #883

Ms2ger commented Oct 2, 2018

binji Oct 4, 2018

binji Oct 5, 2018

Ms2ger Oct 11, 2018

binji Oct 11, 2018

binji Oct 5, 2018

Ms2ger Oct 11, 2018

binji Oct 11, 2018

binji Oct 5, 2018

binji Oct 5, 2018

binji Oct 5, 2018

littledan commented Oct 9, 2018

Ms2ger commented Oct 10, 2018

littledan commented Oct 10, 2018 •

edited

Loading

binji commented Oct 10, 2018

binji commented Oct 12, 2018

Ms2ger commented Oct 15, 2018

binji commented Oct 16, 2018 •

edited

Loading

Import jsapi tests from WPT. #883

Import jsapi tests from WPT. #883

Conversation

Ms2ger commented Oct 2, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

littledan commented Oct 9, 2018

Ms2ger commented Oct 10, 2018

littledan commented Oct 10, 2018 • edited Loading

binji commented Oct 10, 2018

binji commented Oct 12, 2018

Ms2ger commented Oct 15, 2018

binji commented Oct 16, 2018 • edited Loading

littledan commented Oct 10, 2018 •

edited

Loading

binji commented Oct 16, 2018 •

edited

Loading