Disallow using internal globals in constant expressions #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
1 similar comment
|
lgtm |
rossberg
force-pushed
the
master
branch
2 times, most recently
from
bace049
to
e7632dc
Compare
ngzhian
pushed a commit
to ngzhian/spec
that referenced
this pull request
Nov 4, 2021
ngzhian
added a commit
to ngzhian/spec
that referenced
this pull request
Nov 4, 2021
…#466) * [interpreter] Implement i32x4.trunc_sat_f64x2_{s,u}_zero This converts 2 f64 to 2 i32, then zeroes the top 2 lanes. These 2 instructions were merged as part of WebAssembly#383. This change also refactors some test cases from simd_conversions out into a script that generates both i32x4.trunc_sat_i32x4_{s,u} and i32x4.trunc_sat_f64x2_{s,u}_zero. * Add encode/decode * Update interpreter/exec/simd.ml Co-authored-by: Andreas Rossberg <[email protected]> Co-authored-by: Andreas Rossberg <[email protected]>
ngzhian
added a commit
to ngzhian/spec
that referenced
this pull request
Nov 4, 2021
These 2 instructions were merged as part of WebAssembly#383. The test cases are add manually to simd_conversions.wast, using constants from test/core/conversions.wast.
ngzhian
added a commit
to ngzhian/spec
that referenced
this pull request
Nov 4, 2021
These 2 instructions were merged as part of WebAssembly#383.
ngzhian
added a commit
to ngzhian/spec
that referenced
this pull request
Nov 4, 2021
Instructions were added in WebAssembly#383. Consolidate conversion operations (vcvtop) more, merging int-int widening operations. Drive-by fix extmul definition in syntax (shouldn't include the shape).
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address #367