More tests! #274
Merged
More tests! #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds more floating point rounding tests, more expression optimizer bait tests, more real-world floating point bug tests, and more comments.
|
LGTM, though I haven't checked in detail. |
|
Merging, with a qualified LGTM, as this is just adding tests and not changing any spec code. And of course, these and all tests continue to be subject to review at any time by anyone interested. |
ngzhian
added a commit
to ngzhian/spec
that referenced
this pull request
Nov 4, 2021
i8x16, i16x8, i32x4, i64x2, f32x4, f64x2 splats. Implemented using Convert ast as a splat essentially takes a value of every other type to V128.
rossberg
pushed a commit
that referenced
this pull request
Feb 28, 2024
This cherry-picks interpreter changes from https://github.com/WebAssembly/tail-call to run spec tests that mix `try`s with `return_call(_indirect)`s (#275). When tail-call is merged to the main spec repo, we can revert this change and merge the upstream spec. This also adds missing handling for `ReturningInvoke` in the new `Catch`/`Caught`/`Delegate` instructions in the evaluator.
rossberg
pushed a commit
that referenced
this pull request
Feb 28, 2024
This adds tests of `return_call(_indirect)`s within `try`s. Because this repo's interpreter doesn't have the tail call support, this requires #274 to be merged before merging. These test also needs `--experimental-wasm-return_call` to `node` argument in the CI to pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds more floating point rounding tests, more expression optimizer
bait tests, more real-world floating point bug tests, and more comments.