Add invalid command #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewagner
force-pushed
the
add-invalid-command
branch
from
bc90f5d
to
14b3b7f
Compare
lukewagner
force-pushed
the
add-invalid-command
branch
from
14b3b7f
to
c8af2a5
Compare
|
Oops, this should do it. |
|
LGTM |
littledan
pushed a commit
to littledan/spec
that referenced
this pull request
Mar 4, 2018
awendland
pushed a commit
to awendland/webassembly-spec-abstypes
that referenced
this pull request
Mar 26, 2020
* [js-api] Remove spurious argument to ToWebAssemblyValue(). Fixes WebAssembly#51. * [js-api] Extend the WebAssembly.Table API. Fixes WebAssembly#22. Fixes WebAssembly#67.
ErikMcClure
pushed a commit
to innative-sdk/spec
that referenced
this pull request
Jun 15, 2020
Set up deploy key
rossberg
referenced
this pull request
in effect-handlers/wasm-spec
Feb 15, 2021
Merge with upstream ref-types
backes
pushed a commit
to backes/spec
that referenced
this pull request
Jul 12, 2023
dhil
added a commit
to dhil/webassembly-spec
that referenced
this pull request
Jan 25, 2024
Merge with WebAssembly/function-references
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Apr 12, 2024
A few more typo fixes in Explainer.md
rossberg
pushed a commit
that referenced
this pull request
Jul 3, 2024
rossberg
pushed a commit
that referenced
this pull request
Sep 4, 2024
rossberg
pushed a commit
that referenced
this pull request
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two patches (on top of #14):
The first patch adds an
(invalid (module ...) "error")command that checks that the given module fails in the checker (as opposed to during parsing which is outside the spec) with the given"error". This command is then used to test the corner cases of thememorysection.The second patch added tests for the corner cases of exports and caught a minor "bug"—the AST is allowed to export a single name twice—which is fixed.