Update function pointers to match design #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| List.iter (fun xI -> check_func_type (func xI) s xI.at) xs; | ||
| tables @ [s] | ||
| let check_elem c x = | ||
| require (x.it >= 0 && x.it < List.length c.funcs) x.at |
There was a problem hiding this comment.
Why not simply do ignore (func c x) ?
|
LGTM modulo comments |
|
LGTM |
lukewagner
added a commit
that referenced
this pull request
Oct 15, 2015
Update function pointers to match design
Closed
alexcrichton
pushed a commit
to alexcrichton/spec
that referenced
this pull request
Nov 18, 2019
[test] Integrate tests for f64x2 min/max/abs ops from WAVM
Connicpu
pushed a commit
to Connicpu/wasm-spec
that referenced
this pull request
Jun 7, 2020
Decoding 64 as an signed LEB will produce the value -64 = 4294967232. This change adds tests to ensure that the segment is decoded as 64.
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Mar 2, 2023
This renames existing old proposals by adding a version number to filenames and adds the current (=soon-to-be-previous) proposal to the old/folder as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates function pointers semantics to match design/#392. Pretty easy after #133.