[js-api] Bump limit for maximum memory size to 4GiB #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per discussion in WebAssembly#1116, the limit for initial memory pages remains at 32767 (just under 2GiB), while the limit for maximum memory pages is increased to 65536 (4GiB). Spec tests are brought in line with these definitions (they actually did not reflect the spec text before). Fixes: WebAssembly#1116.
|
I have created a W3C account and linked it, but now when I click "Revalidate"in the ipr checker I get an error "Authentication required." Am I holding it wrong? |
ExE-Boss
reviewed
Feb 4, 2020
binji
approved these changes
Feb 4, 2020
I clicked revalidate; it seems the issue is that you're not a member of the wasm CG: https://www.w3.org/community/webassembly/participants. |
lars-t-hansen
approved these changes
Feb 7, 2020
pull bot
pushed a commit
to p-g-krish/v8
that referenced
this pull request
Feb 24, 2020
Make sure the "initial pages" memory limit is enforced correctly and throws a CompileError when exceeded. Bump the "maximum pages" memory limit to 65536. The --wasm-max-mem-pages flag now controls the "initial pages" limit; the "maximum pages" limit is always 65536 as spec'ed. This CL depends on WebAssembly/spec#1121. Bug: v8:7881, v8:8633 Change-Id: I68d07cef56633b8b8ce3b3d047c14e1096daf547 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2035876 Reviewed-by: Andreas Haas <[email protected]> Reviewed-by: Georg Neis <[email protected]> Commit-Queue: Jakob Kummerow <[email protected]> Cr-Commit-Position: refs/heads/master@{#66400}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in #1116, the limit for initial memory pages remains at
32767 (just under 2GiB), while the limit for maximum memory pages is
increased to 65536 (4GiB).
Spec tests are brought in line with these definitions (they actually did
not reflect the spec text before).
Fixes: #1116.