-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec for Memory object's constructor does not check maximum >= initial #876
Comments
Good spot! It seems like ideally this validation of the limits would happen using the core spec's validation rule for memory types and table types. Maybe the simplest place for this might be in the core spec |
Oops, I hadn't reached #877 yet in my bugmail. Either approach works, I suppose. |
@lukewagner, yes it would make sense to add these as explicit pre/side conditions. I'll do that. |
Closing per #877 |
The descriptor passed to WebAssembly.Memory's constructor has two fields, initial and maximum, where maximum is optional. If maximum is present then there needs to be a check that it is no smaller than than initial, but there's no such check. WebAssembly.Table's constructor does have such a check.
EDIT: Fixed ">" to ">=", though subject line and @binji's PR were both correct, so editorial only.
The text was updated successfully, but these errors were encountered: