Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[js-api] "Creating a host function" requires a functype parameter #768

Closed
rossberg opened this issue Apr 9, 2018 · 2 comments
Closed

[js-api] "Creating a host function" requires a functype parameter #768

rossberg opened this issue Apr 9, 2018 · 2 comments
Assignees
@littledan

Comments

@rossberg
Copy link
Member

rossberg commented Apr 9, 2018

The algorithm to create a host function uses the function's type:

  • in step 1.1 implicitly as "the signature",
  • in step 1.6 as |functype|.

However, that type is not actually provided. The algorithm needs to take |functype| as a parameter.
@rossberg rossberg mentioned this issue Apr 9, 2018
Merged
Ms2ger added a commit to Ms2ger/spec that referenced this issue Aug 9, 2018
@Ms2ger
[js-api] Pass a functype parameter to "create a host function".
24e291c 
Fixes WebAssembly#768.
@ericprud ericprud closed this as completed Sep 5, 2018
@littledan
Copy link
Collaborator

This is actually fixed only in 24e291c cc @Ms2ger

@littledan littledan reopened this Sep 6, 2018
@littledan
Copy link
Collaborator

That patch landed too, so closing.

Ms2ger added a commit to Ms2ger/spec that referenced this issue Jan 25, 2019
@Ms2ger
[js-api] Pass a functype parameter to "create a host function".
71d5c9f 
Fixes WebAssembly#768.
littledan pushed a commit that referenced this issue Jan 25, 2019
@Ms2ger @littledan
[js-api] Pass a functype parameter to "create a host function".
421fab1 
Fixes #768.
@binji binji mentioned this issue May 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@littledan littledan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@littledan @ericprud @rossberg