Remove unsigned dot product from overview #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why? |
|
Oh, misread #52. In the description, you cancelled the i32x4 dot products, i think that's a mistake. It should be removing unsigned dot products. |
| | `i32x4.dot_i8x16_i7x16_add_u` | 0x115 | unimplemented | | ||
| | Reserved for bfloat16 | 0x116 | unimplemented | | ||
| | Reserved | 0x117 - 0x12F | | | ||
| | `i32x4.dot_i8x16_i7x16_add_s` | 0x113 | unimplemented | |
There was a problem hiding this comment.
Just to confirm: we are changing i32x4.dot_i8x16_i7x16_add_s code here
There was a problem hiding this comment.
Yea, or do you think we should leave a gap in case we figure something out?
There was a problem hiding this comment.
That's fine as changed (to not leave a gap). I was checking and commenting since current implementations need to adjust that.
There was a problem hiding this comment.
We haven't prototyped this yet, so no objections to the opcode number being changed.
ngzhian
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.