-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec test updates #91
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic, thanks for working on this Ben!
I wonder if we should split out the js-tests into a separate PR since they seem logically separate to me (and the imports.wast
change includes other misc changes for multi-memory)?
Converting to draft while I update the spec tests to reflect the change to "address type". 📣 ATTENTION! 📣 This is your last chance to bikeshed the name of the parameter used in memory and table descriptors! It used to be |
"addressType" sounds good to me. This PR is not updated for that yet, right? |
@eqrion has pointed out to me that WebAssembly.Global uses "value" for the global's value type, and WebAssembly.Table uses "element" for the element type. Given that precedent, I'm now strongly feeling like it should be "address" instead of "addressType". Sorry I didn't think of this sooner, but hopefully it's no trouble for people to support once I get it in the spec. |
addressType seems like the most explicit. Its more verbose but probably better to be explicit, right? |
No strong preference between |
I would also prefer |
Given the prior positive reviews, and no dissent on the change to |
Import upstream spec tests, in particular including WebAssembly/memory64#91 and WebAssembly/memory64#92. [email protected] Bug: 364917766 Change-Id: I0dd2afab787e1257ee018fdf214bb9173c414572 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5968220 Reviewed-by: Eva Herencsárová <[email protected]> Commit-Queue: Clemens Backes <[email protected]> Cr-Commit-Position: refs/heads/main@{#96851}
Adds core and JS API spec tests for recent updates as described in #80.
We needed fewer updates than I had originally thought. See the individual commits. Tests I did not have to write include:
Beyond adding tests for memory64, I also took the opportunity to significantly enhance the memory import tests, since multi-memory is now standard.
Resolves #80.