[table64] Fix validation rules for table.fill/copy/size/grow #54
Conversation
|
Actually it looks like table init and copy test files are auto-generated, so looking at updating the generators . |
Also, add more tests.
|
table_init.wast and table_copy.wast are now correctly auto-generated from the meta scripts |
| require (it1 = it2) x.at | ||
| ("type mismatch: source index type " ^ string_of_index_type it1 ^ | ||
| " does not match destination index type " ^ string_of_index_type it2); |
There was a problem hiding this comment.
I think this may not match memories where you can copy between 32/64-bit memories ok?
There was a problem hiding this comment.
The issue of copying between memories has not come up before since multi-memories have historically not been a thing. In fact, the memory.copy instruction currently only take a single memory so its a non-issue there. See #55.
There was a problem hiding this comment.
Oh I did bring this up a few years back and I implemented that issue's proposed solution in Wasmtime which has been there for some time now.
I don't have a strong motivation myself, but at least personally if table64 is added this doesn't seem really that much more of a stretch.
Also, add more tests.