Merge from upstream spec #262

aheejin · 2023-02-17T22:39:05Z

No description provided.

…tly (#1567)

It previously stated that the formal spec did not exist, but the spec has existed for years now.

Fixes #1138.

dschuff

LGTM, but IMO you don't really even need a review on this kind of change

aheejin · 2023-02-18T01:55:59Z

Currently the CI has two failures. One is 'build-core-spec' failure, which is also reproduced in the spec repo (WebAssembly/spec#1603).

The other is 'ref-interpreter' fails on binary.wast (https://github.com/WebAssembly/exception-handling/actions/runs/4208770248/jobs/7305156280, which I'm not sure why. This failure is not reproduced in my local machine. This is the reason why I'm now trying various random changes and reverting (by force-pushing) them.

(I'm now trying to revert commits in the merge to figure out which commit is causing the issue. All these reverting commits will be re-reverted.)

aheejin · 2023-02-18T02:25:25Z

It looks 31cabf8 (from WebAssembly/spec#1595) is causing the 'ref-interpreter' failure (https://github.com/WebAssembly/exception-handling/actions/runs/4209147102/jobs/7305884276), but I haven't figured out why or why it's not causing the same problem in the spec repo.

aheejin · 2023-02-18T09:39:56Z

I was able to reproduce the error on my machine now. The command is

(from the interpreter dir)
$ ../test/core/run.py --wasm $PWD/wasm --js node

And the node should be v18, as 31cabf8 says. (My local node was a newer one, v19.5, which is the current LTS. The error was not reproduced on this version.) Haven't figured out why node v18 fails only on the EH repo (and not the spec repo) yet. I didn't even know we need node to run the core spec tests....

The issues appears to be related to actions/runner-images#7002. Co-authored-by: Ms2ger <[email protected]>

rossberg · 2023-02-21T11:14:38Z

The test likely fails because node does not yet implement/expose exception handling. Until it does, you'll have to remove the JS=node on line 26 of .github/workflows/main.yml to deactivate running the test suite through node in CI.

I don't know why the spec build started failing, that was news to me.

JSC will have to do asynchronous compilation work during some instantiations. To be consistent, this PR always queues a task to complete instantiation, except through the synchronous Instance(module) API, to ensure consistency across platforms. This patch also cleans up the specification in various surrounding ways: - Include notes about APIs whose use is discouraged/may be limited Closes #741 See also webpack/webpack#6433

The section name has changed to the tag section a few years ago. This adds the corresponding changes added in WebAssembly#252 and WebAssembly#256.

aheejin · 2023-02-22T21:53:21Z

@rossberg

The test likely fails because node does not yet implement/expose exception handling. Until it does, you'll have to remove the JS=node on line 26 of .github/workflows/main.yml to deactivate running the test suite through node in CI.

Node started to support EH without a flag starting v17: https://webassembly.org/roadmap/
So it's a node issue but doesn't seem to be the version issue. I'm trying to figure out what the issue is. (Node v19 doesn't have the issue anymore)

By the way I thought core spec tests are run by the reference interpreter... Are they run by node instead now? What happens if I comment out that node line? Are they run by the interpreter or not run?

aheejin · 2023-02-22T23:49:08Z

@Ms2ger Sorry, but I'm asking this for the third time now. Can you please let me merge my own PRs, in the WebAssembly repos where I have write access? The ref-interpreter CI was failing and I was trying to fix it before merging. As I said in my previous comments as well, I prefer merging my PRs myself, for these reasons:

When I ask review for multiple reviewers, I want to wait for some more time for other reviewers to comment so I can address them.
There can be some CI errors I want to address before merging.
I want to edit my commit messages and prefer that over an automatically generated commit message, which concatenates all my individual commits in that PR.

Given that almost all people who post PRs in this repo have write access anyway, can we leave PRs to be merged by authors, maybe at least in this repo?

rossberg · 2023-02-23T07:59:02Z

By the way I thought core spec tests are run by the reference interpreter... Are they run by node instead now? What happens if I comment out that node line? Are they run by the interpreter or not run?

They are run by both. The node run is to ensure that the JS test generation of the interpreter works correctly. If you don't set the js command then it will still convert the tests to JS but not test the result.

rossberg and others added 24 commits December 12, 2022 23:37

[interpreter] Refactor parser to handle select & call_indirect correc…

ef01de5

…tly (#1567)

[spec] Remove dead piece of grammar

a54a1d8

[test] elem.wast: force to use exprs in a element (#1561)

1782235

Fix typos in SIMD exec/instructions

ca1d792

Update interpreter README (#1571)

4c249c5

It previously stated that the formal spec did not exist, but the spec has existed for years now.

[spec] Remove an obsolete exec step (#1580)

f54b5b8

[test] Optional tableidx for table.{get,set,size,grow,fill} (#1582)

6798f05

[spec] Fix abstract grammar for const immediate (#1577)

7d905df

[spec] Fix context composition in text format (#1578)

0031ea4

[spec] Fix label shadowing (#1579)

dcf4eaa

[spec] Fix typos in instruction index (#1584)

45f9845

[spec] Fix typo (#1587)

947badf

[spec] Remove inconsistent newline (#1589)

b1fbe1a

[interpreter] Remove legacy bigarray linking (#1593)

2b4222d

[spec] Show scrolls for overflow math blocks (#1594)

aa15776

[interpreter] Run JS tests via node.js (#1595)

31cabf8

[spec] Remove stray x indices (#1598)

e7f6e1c

[spec] Style tweak for cross-refs

f8ae6b2

[spec] Style eps (#1601)

0f06880

[spec] Clarify that atoms can be symbolic (#1602)

328e425

[test] Import v128 global (#1597)

deeb164

[js-api] Expose everywhere

19b1243

[js-api] Try to clarify NaN/infinity handling. (#1535)

4feb919

[web-api] Correct MIME type check. (#1537)

51ff50a

Fixes #1138.

aheejin requested a review from dschuff February 17, 2023 22:39

dschuff approved these changes Feb 18, 2023

View reviewed changes

aheejin force-pushed the merge_spec branch 2 times, most recently from af1d6ac to 09e3b45 Compare February 18, 2023 01:52

aheejin force-pushed the merge_spec branch from 33af7d5 to 09e3b45 Compare February 18, 2023 02:07

aheejin force-pushed the merge_spec branch from 0b97e96 to a0065f1 Compare February 18, 2023 02:20

aheejin force-pushed the merge_spec branch 3 times, most recently from ef6d3e2 to a0065f1 Compare February 18, 2023 09:29

aheejin force-pushed the merge_spec branch from a0065f1 to 09e3b45 Compare February 18, 2023 09:40

aheejin and others added 2 commits February 21, 2023 11:53

[ci] Pin nodejs version to avoid fetching failures (#1603)

e8a83b2

The issues appears to be related to actions/runner-images#7002. Co-authored-by: Ms2ger <[email protected]>

[spec] Add missing value to table.grow reduction rule (#1607)

3545ad0

rossberg and others added 6 commits February 21, 2023 12:28

[test] Move SIMD linking test to simd dir (#1610)

585bfa7

Editorial: Clarify the name of the instantiate algorithm.

f9a7267

Add notes to discourage using synchronous APIs.

a114f7a

[test] Exception -> Tag in wasm-module-builder.js

036365a

The section name has changed to the tag section a few years ago. This adds the corresponding changes added in WebAssembly#252 and WebAssembly#256.

Merge upstream.

87c964f

Ms2ger force-pushed the merge_spec branch from 2ae37bf to 87c964f Compare February 22, 2023 09:29

Ms2ger merged commit 87c964f into WebAssembly:main Feb 22, 2023

aheejin deleted the merge_spec branch February 22, 2023 19:00

aheejin mentioned this pull request Feb 23, 2023

[test] Fix invalid section ID tests WebAssembly/spec#1615

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge from upstream spec #262

Merge from upstream spec #262

aheejin commented Feb 17, 2023

dschuff left a comment

aheejin commented Feb 18, 2023 •

edited

Loading

aheejin commented Feb 18, 2023 •

edited

Loading

aheejin commented Feb 18, 2023 •

edited

Loading

rossberg commented Feb 21, 2023 •

edited

Loading

aheejin commented Feb 22, 2023 •

edited

Loading

aheejin commented Feb 22, 2023 •

edited

Loading

rossberg commented Feb 23, 2023

Merge from upstream spec #262

Merge from upstream spec #262

Conversation

aheejin commented Feb 17, 2023

dschuff left a comment

Choose a reason for hiding this comment

aheejin commented Feb 18, 2023 • edited Loading

aheejin commented Feb 18, 2023 • edited Loading

aheejin commented Feb 18, 2023 • edited Loading

rossberg commented Feb 21, 2023 • edited Loading

aheejin commented Feb 22, 2023 • edited Loading

aheejin commented Feb 22, 2023 • edited Loading

rossberg commented Feb 23, 2023

aheejin commented Feb 18, 2023 •

edited

Loading

aheejin commented Feb 18, 2023 •

edited

Loading

aheejin commented Feb 18, 2023 •

edited

Loading

rossberg commented Feb 21, 2023 •

edited

Loading

aheejin commented Feb 22, 2023 •

edited

Loading

aheejin commented Feb 22, 2023 •

edited

Loading