Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update constant value for exnref type #92

Closed
sbc100 opened this issue Dec 26, 2019 · 3 comments
Closed

Update constant value for exnref type #92

sbc100 opened this issue Dec 26, 2019 · 3 comments

Comments

@sbc100
Copy link
Member

sbc100 commented Dec 26, 2019

We are currently using -0x18, but that slot just used by reference-types for nullref:
WebAssembly/reference-types#66
@aheejin
Copy link
Member

aheejin commented Dec 26, 2019

I think that -18 in WebAssembly/reference-types#66 is in decimal, while our -0x18 is in hexadecimal.

@sbc100
Copy link
Member Author

sbc100 commented Dec 26, 2019

Oh, that case wabt is just wrong I guess: https://github.com/WebAssembly/wabt/blob/76ff3af40040a90c15b6b9f2614f3a3869dbdab1/src/common.h#L217

I'll propose a change there.

sbc100 added a commit to WebAssembly/wabt that referenced this issue Dec 26, 2019
@sbc100
Change encoding of Exnref to -0x12
a2a1abf 
The spec for this was specified as -18 in decimal which is -0x12 in hex.

Fixes: WebAssembly/exception-handling#92
@sbc100 sbc100 mentioned this issue Dec 26, 2019
Closed
@aheejin
Copy link
Member

aheejin commented Dec 26, 2019

Not sure what you mean. The current wabt implementation looks correct. Exnref is -0x18, in hexadecimal.

@sbc100 sbc100 closed this as completed Jan 8, 2020
ioannad pushed a commit to ioannad/exception-handling that referenced this issue Jun 6, 2020
@binji
[spec] Add memory.init and data.drop for exec (WebAssembly#92)
0ee9e67
ioannad pushed a commit to ioannad/exception-handling that referenced this issue Jun 6, 2020
@binji
[spec] Use optional data instance, not data address (WebAssembly#93)
80aea4a 
data.drop must update the store, not the frame. There may be multiple
copies of the frame, so any updates will only update once. We can make
sure that all copies are updated by using an indirection through data
addresses and updating the store instead.

See discussion in PR WebAssembly#92.
ioannad pushed a commit to ioannad/exception-handling that referenced this issue Jun 6, 2020
@gahaas
[tests] Delete leftover harness function (WebAssembly#92)
a83b16e 
In the generated test files the generic imports contained a function that does not exist anymore. This caused all tests to fail. This PR removes the function from the imports.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change encoding of Exnref to -0x12 WebAssembly/wabt
2 participants
@sbc100 @aheejin