[NFC] Finalize blocks with explicit breakability in IRBuilder #7085
Conversation
Since IRBuilder already knows what labels are used by branches, it is easy for it to pass that information when finalizing blocks. This avoids finalization having to walk the blocks looking for branches, speeding up a future version of the binary parser that uses IRBuilder by 10%.
| // correct types. ReFinalize now to fix any issues. | ||
| PassRunner runner(getPassRunner()); | ||
| runner.add(std::make_unique<ReFinalize>()); | ||
| runner.run(); |
There was a problem hiding this comment.
This comment sort of suggests to me that Outlining should not be using IRBuilder...? What does "an odd order" mean?
lgtm otherwise
There was a problem hiding this comment.
Outlining visits control flow expressions in a breadth-first order rather than doing a normal postorder traversal. So it visits every top-level expression in a function body, ends the function, then visits the contents of every block it saw while traversing those top-level expressions, etc. Another way to look at it is that Outlining uses IRBuilder to build one control flow structure at a time rather than a whole function at at a time.
There was a problem hiding this comment.
This "odd" traversal should be well documented in passes/stringify-walker.h.
There was a problem hiding this comment.
Ok, sounds good. Maybe add a link to there?
Since IRBuilder already knows what labels are used by branches, it is
easy for it to pass that information when finalizing blocks. This avoids
finalization having to walk the blocks looking for branches, speeding up
a future version of the binary parser that uses IRBuilder by 10%.