Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark Result and MaybeResult [[nodiscard]] #7083

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Mark Result and MaybeResult [[nodiscard]] #7083

merged 1 commit into from
Nov 15, 2024
+13 −13

Commits on Nov 15, 2024

  1. Mark Result and MaybeResult [[nodiscard]] 

    Since these types may be carrying errors that need to be handled or
propagated, it is always an error not to use them in some way. Adding
the [[nodiscard]] attribute caused the compiler to find a few instances
where we were incorrectly ignoring results. Fix these places.
    @tlively
    tlively committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    94996bc View commit details
    Browse the repository at this point in the history