Binary parser: lift the limit on the number of locals #6973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This raises the number of locals accepted by the binary parser to the absolute limit in the spec. A warning is now printed when writing a binary file if the Web limit of 50,000 locals is exceeded. This fixes WebAssembly#6968.
kripken
reviewed
Sep 26, 2024
src/wasm/wasm-binary.cpp
Outdated
| @@ -2722,16 +2726,18 @@ void WasmBinaryReader::readFunctions() { | |||
| void WasmBinaryReader::readVars() { | |||
| uint32_t totalVars = 0; | |||
| size_t numLocalTypes = getU32LEB(); | |||
| std::vector<std::pair<uint32_t, Type>> decodedVars; | |||
There was a problem hiding this comment.
Suggested change
| std::vector<std::pair<uint32_t, Type>> decodedVars; | |
| // Use a SmallVector as in the common (MVP) case there are only 4 possible types. | |
| SmallVector<std::pair<uint32_t, Type>, 4> decodedVars; |
|
Looks good aside from one suggestion. Also, I think we can test this in |
kripken
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This raises the number of locals accepted by the binary parser to the absolute limit in the spec. A warning is now printed when writing a binary file if the Web limit of 50,000 locals is exceeded. This fixes #6968.