Add the upstream spec testsuite as a submodule #6853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run the upstream tests by default, except for a large list of them that do not successfully run. Remove the local version of those that do successfully run where the local version is entirely subsumed by the upstream version.
kripken
approved these changes
Aug 20, 2024
|
Will investigate the wasm2js test failures and upload fixes in preliminary PRs. |
|
If it's anything non-trivial in wasm2js then it's probably ok to disable the tests there specifically (we do want to keep wasm2js working, but it isn't worth adding more functionality unless we have specific reasons). |
Including by skipping one that is not supported. Also ignore more unsupported assertions in wasm2js.
|
The changes ended up being minor enough that I just included them here. PTAL! |
kripken
approved these changes
Aug 20, 2024
Closed
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run the upstream tests by default, except for a large list of them that
do not successfully run. Remove the local version of those that do
successfully run where the local version is entirely subsumed by the
upstream version.