Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[threads] Allow i31refs of mixed shareability to compare equal (#6752)" #6761

Merged
merged 1 commit into from
Jul 17, 2024

Commits on Jul 17, 2024

  1. Revert "[threads] Allow i31refs of mixed shareability to compare equal (

    #6752)"
    
    Allowing Literals with different types to compare equal causes problems
    for passes that want equality to mean real equality, e.g. because they
    are using literals as map keys or because they otherwise need to use
    them interchangeably.
    
    At a minimum, we would need to differentiate a `refEq` operation where
    mixed-shareability i31refs can compare equal from physical equality on
    Literals, but there is also appetite to disallow mixed-shareability
    ref.eq at the spec level. See
    WebAssembly/shared-everything-threads#76.
    tlively committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    b803318 View commit details
    Browse the repository at this point in the history