Re-enable spec tests requiring multivalue #6684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
force-pushed
the
spec-test-offset64
branch
from
c64bbe5
to
e3bc30c
Compare
tlively
force-pushed
the
spec-test-multivalue
branch
from
27feb61
to
ec2e427
Compare
tlively
force-pushed
the
spec-test-offset64
branch
from
e3bc30c
to
baa8b95
Compare
tlively
force-pushed
the
spec-test-multivalue
branch
from
ec2e427
to
8dbc1f5
Compare
This will hopefully fix the build on the coverage builder.
For 32-bit memories, the offset value must be in the u32 range. Update the address.wast spec test to assert that a module with an overlarge offset value is invalid rather than malformed.
And delete tests that no longer pass now that multivalue is standard.
tlively
force-pushed
the
spec-test-offset64
branch
from
baa8b95
to
9119575
Compare
tlively
force-pushed
the
spec-test-multivalue
branch
from
8dbc1f5
to
b89daa6
Compare
kripken
approved these changes
Jun 20, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And delete tests that no longer pass now that multivalue is standard.