Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Parser] Fix error message on required reftype #6666

Merged
merged 2 commits into from
Jun 14, 2024
Merged

[Parser] Fix error message on required reftype #6666

merged 2 commits into from
Jun 14, 2024

Commits on Jun 14, 2024

  1. [Parser] Update requirements for implicit type uses 

    As an abbreviation, a `typeuse` can be given as just a list of parameters and
results, in which case it corresponds to the index of the first function type
with the same parameters and results. That function type must also be an MVP
function type, i.e. it cannot have a nontrivial rec group, be non-final, or have
a declared supertype. The parser did not previously implement all of these rules.
    @tlively
    tlively committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    427de00 View commit details
    Browse the repository at this point in the history

  2. [Parser] Fix error message on required reftype 

    Not all uses of the `reftype` parser handled the fact that it returned a
`MaybeResult`. Change its name to `maybeReftype`, add a new `reftype` parser
that returns an error if there is no reftype, and update all the use sites.

Fixes #6655.
    @tlively
    tlively committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    a15ab53 View commit details
    Browse the repository at this point in the history