[threads] Add a "shared-everything" feature #6658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Jun 13, 2024
src/wasm/wasm-type.cpp
Outdated
| @@ -949,7 +955,9 @@ FeatureSet Type::getFeatures() const { | |||
| if (sig.results.isTuple()) { | |||
| feats |= FeatureSet::Multivalue; | |||
| } | |||
| } else if (heapType->isContinuation()) { | |||
| } | |||
There was a problem hiding this comment.
Can something be both a signature and a continuation?
There was a problem hiding this comment.
No, but the original else-if up above was incorrect because it is possible for something to have a non-trivial rec group or have a declared supertype or be open and also be a signature. Rather than mix ifs and if-elses, I just made everything an if.
There was a problem hiding this comment.
Yeah, that part made sense to me. But maybe it's still good to have an if-else chain after it, for the disjoint cases? That seems clearer to me (even if it might lead to some overlapping code).
Add the feature and flags to enable and disable it. Require the new feature to be enabled for shared heap types to validate. To make the test work, update the validator to actually check features for global types.
kripken
approved these changes
Jun 14, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the feature and flags to enable and disable it. Require the new feature to
be enabled for shared heap types to validate. To make the test work, update the
validator to actually check features for global types.