-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NFC] Disable a warning that happens on system headers on CI #6597
Conversation
Trying to skip the include line that errored did not help as it errored on the next place to include it. It seems like this is a new warning in clang that is firing on system headers, so I'm not sure if we can do anything aside from disable the warning, which I pushed now, or bundle our own libc++. This PR now disables the warning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we put this in the cmake config instead? That would prevent the error from affecting anyone locally, too.
Well, I don't know if this is some weird thing on the CI machines. We've never gotten a report of this before til CI started to error. If this is just CI picking up on an update to some common distro then maybe we should. But I'm not sure how to check that. The readme file that tracks what |
But I guess it's such an unimportant warning we can just do it in cmake, to be safe. Done. |
CI started to error here, after some infra changes apparently:
https://github.com/WebAssembly/binaryen/actions/runs/9099538230/job/25012304693