Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug location parser: accept arbitrary paths #6594

Merged
merged 2 commits into from
May 15, 2024
Merged

Debug location parser: accept arbitrary paths #6594

merged 2 commits into from
May 15, 2024

Conversation

vouillon
Copy link
Contributor

The whole annotation was parsed as a keyword, which prevented file paths with non-ascii characters or paths starting with / or ..

Also, there was a typo: one was comparing fileSize rather than lineSize to contents->npos.

tlively
tlively approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@tlively tlively merged commit b70d8df into WebAssembly:main May 15, 2024
13 checks passed
@vouillon vouillon deleted the debug-file-names branch May 15, 2024 19:32
@gkdn gkdn mentioned this pull request Aug 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlively tlively tlively approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vouillon @tlively