[Strings] Fuzzer: Emit StringConcat #6532
Conversation
| // We much less frequently make string.concat as it will recursively | ||
| // generate two string children, i.e., it can lead to exponential | ||
| // growth. |
There was a problem hiding this comment.
Isn't this true of lots of instructions, though? Don't we have some depth limiting mechanism that already takes care of this?
There was a problem hiding this comment.
We do have a limit, yeah, but it is nice to avoid reaching it I think (as reaching it has downsides - we've exhausted input bytes). And this still gives a reasonable chance for concat to happen I think.
| RefNull : 5 | ||
| Return : 3 | ||
| Store : 1 | ||
| StringConst : 1 |
There was a problem hiding this comment.
Maybe tweak the input data again? It looks like this single StringConst is the only string instruction generated.
There was a problem hiding this comment.
Heh, I thought the same and tinkered with it for maybe 10 minutes before giving up. It's just very hard to get it to emit the right stuff here without stopping to emit other stuff (like GC instructions) by chance. Perhaps if we had a very large input, or multiple input files, that would be better... but I'm not sure it's worth it.
Also refactor the code a little to make it easier to add this.
Diff without whitespace is much smaller.