Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OptimizeInstructions: Optimize subsequent struct.sets after struct.new_with_default #6523

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

kripken
Copy link
Member

@kripken kripken commented Apr 22, 2024

Before we preferred not to add default values, as that increases code size. But since
#6495 we turn more things into struct.new_with default, so it is important to handle
this. It seems likely that in most cases the code size downside of adding default
values is offset by avoiding a local.set later, so always do this (rather than add some
kind of heuristic).

@kripken kripken requested a review from tlively April 22, 2024 23:57
@kripken kripken merged commit bceb02d into WebAssembly:main Apr 23, 2024
13 checks passed
@kripken kripken deleted the subsequent.set.default branch April 23, 2024 15:33
@gkdn gkdn mentioned this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants