OptimizeInstructions: Optimize subsequent struct.sets after struct.new_with_default #6523
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we preferred not to add default values, as that increases code size. But since
#6495 we turn more things into
struct.new_with default
, so it is important to handlethis. It seems likely that in most cases the code size downside of adding default
values is offset by avoiding a
local.set
later, so always do this (rather than add somekind of heuristic).