Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Strings] Fix finalize() of StringNew on arrays #6511

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

kripken
Copy link
Member

@kripken kripken commented Apr 18, 2024

We added two fields to StringNew at some point but forgot to update the finalize method.

@kripken kripken requested a review from tlively April 18, 2024 18:39
@kripken kripken merged commit d39b4fa into WebAssembly:main Apr 18, 2024
13 checks passed
@kripken kripken deleted the string.new.unreachable branch April 18, 2024 19:27
@gkdn gkdn mentioned this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants