Fuzzer: Do not run other VMs if the Binaryen interpreter hits a VM limitation #6483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
reviewed
Apr 10, 2024
Comment on lines
-954
to
-961
| # if the binaryen interpreter hit a host limitation on the original | ||
| # testcase, or for some other reason we need to ignore this, then stop | ||
| # (otherwise, a host limitation on say allocations may be hit in the | ||
| # 'before' but not in the 'after' as optimizations may remove it). | ||
| if before[self.bynterpreter] == IGNORE: | ||
| # the ignoring should have been noted during run_vms() | ||
| assert(ignored_vm_runs > ignored_before) | ||
| return |
There was a problem hiding this comment.
Do we still need this logic as well in case the reason for the host limitation is optimized out?
There was a problem hiding this comment.
This function calls run_vms twice, which this PR fixes. It also calls compare_before_and_after, which are passed the results we do have (which will be only the binaryen interpreter, so that should be ok).
tlively
approved these changes
Apr 10, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VM limitation might be an OOM (which can change due to opts) or an
atomic wait (which can hang on proper VMs with support). We already
avoided running VMs on the optimized wasm in this case, but we still
ran them on the original wasm, which this changes, mainly to avoid that
atomic wait situation.