Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strings: Disable precomputing for now #6412

Merged
merged 3 commits into from
Mar 20, 2024
Merged

Strings: Disable precomputing for now #6412

merged 3 commits into from
Mar 20, 2024

Conversation

kripken
Copy link
Member

@kripken kripken commented Mar 20, 2024

Our UTF implementation is still not fully stable it seems as we have reports of
issues. Disable it for now.

@kripken kripken requested a review from tlively March 20, 2024 18:54
@kripken kripken merged commit 70ac213 into WebAssembly:main Mar 20, 2024
13 checks passed
@kripken kripken deleted the no.string.precompute branch March 20, 2024 19:40
kripken added a commit that referenced this pull request Mar 20, 2024
@kripken
Revert "Strings: Disable precomputing for now (#6412)"
e38e96b 
This reverts commit 70ac213.
@kripken kripken mentioned this pull request Mar 20, 2024
Merged
kripken added a commit that referenced this pull request Mar 21, 2024
@kripken
Revert "Strings: Disable precomputing for now (#6412)" (#6413)
32e7f19 
This reverts commit 70ac213.

Reverts #6412

On second thought we found a way to make fixing this less urgent, and the
code size downsides of this are worrying, so let's revert it.
@gkdn gkdn mentioned this pull request Aug 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlively tlively tlively approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kripken @tlively