Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests/Fuzzing: Remove some obsolete experimental V8 flags #6347

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

kripken
Copy link
Member

@kripken kripken commented Feb 26, 2024

Those flags were removed in V8 as the features are no longer experimental. This
PR removes this noise from our logs:

Warning: unknown flag --experimental-wasm-gc.                                                                                                                                                 
Try --help for options                                                                                                                                                                        
Warning: unknown flag --experimental-wasm-typed-funcref.                                                                                                                                      
Try --help for options                                                                         
Warning: unknown flag --experimental-wasm-extended-const.                                                                                                                                     
Try --help for options                                                                         
Warning: unknown flag --wasm-final-types.                                                      
Try --help for options                                                                         

However, older versions of V8 may not work any more without those flags. I
always test on a recent one, and I'm not sure if we have a use for anything
else?

Copy link
Member

@aheejin aheejin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be fine given that the only place V8_OPTS is used in fuzz_opt.py.

@kripken kripken merged commit ac62d28 into WebAssembly:main Feb 28, 2024
14 checks passed
@kripken kripken deleted the d8.flags branch February 28, 2024 22:59
@gkdn gkdn mentioned this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants