-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EH] Add translator from old to new EH instructions #6210
Merged
Merged
Commits on Jan 8, 2024
-
[EH] Add translator from old to new EH instructions
This translates the old Phase 3 EH instructions, which include `try`, `catch`, `catch_all`, `delegate`, and `rethrow`, into the new EH instructions, which include `try_table` (with `catch` / `catch_ref` / `catch_all` / `catch_all_ref`) and `throw_ref`, passed at the Oct 2023 CG meeting. This translator can be used as a standalone tool by users of the previous EH toolchain to generate binaries for the new spec without recompiling, and also can be used at the end of the Binaryen pipeline to produce binaries for the new spec while the end-to-end toolchain implementation for the new spec is in progress. While the goal of this pass is not optimization, this tries to a little better than the most naive implementation, namely by omitting a few instructions where possible and trying to minimize the number of additional locals, because this can be used as a standalone translator or the last stage of the pipeline while we can't post-optimize the results because the whole pipeline (-On) is not ready for the new EH.
Configuration menu - View commit details
-
Copy full SHA for 046ebef - Browse repository at this point
Copy the full SHA 046ebefView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9eb535b - Browse repository at this point
Copy the full SHA 9eb535bView commit details
Commits on Jan 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b13aeae - Browse repository at this point
Copy the full SHA b13aeaeView commit details -
Apply suggestions from code review
Co-authored-by: Thomas Lively <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6c4d17f - Browse repository at this point
Copy the full SHA 6c4d17fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 76978f4 - Browse repository at this point
Copy the full SHA 76978f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for c44a66d - Browse repository at this point
Copy the full SHA c44a66dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 69e7895 - Browse repository at this point
Copy the full SHA 69e7895View commit details
Commits on Jan 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5ef3db8 - Browse repository at this point
Copy the full SHA 5ef3db8View commit details
Commits on Jan 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 87f65d3 - Browse repository at this point
Copy the full SHA 87f65d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0460656 - Browse repository at this point
Copy the full SHA 0460656View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3412caa - Browse repository at this point
Copy the full SHA 3412caaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8659480 - Browse repository at this point
Copy the full SHA 8659480View commit details
Commits on Jan 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6ba7e63 - Browse repository at this point
Copy the full SHA 6ba7e63View commit details -
Update src/passes/TranslateEH.cpp
Co-authored-by: Alon Zakai <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7749560 - Browse repository at this point
Copy the full SHA 7749560View commit details -
Configuration menu - View commit details
-
Copy full SHA for a707ba7 - Browse repository at this point
Copy the full SHA a707ba7View commit details
Commits on Jan 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4fbdf13 - Browse repository at this point
Copy the full SHA 4fbdf13View commit details
Commits on Jan 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 97327b5 - Browse repository at this point
Copy the full SHA 97327b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad35e5a - Browse repository at this point
Copy the full SHA ad35e5aView commit details
Commits on Jan 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 47f9952 - Browse repository at this point
Copy the full SHA 47f9952View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.