Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect wat in tests #6207

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Fix incorrect wat in tests #6207

merged 2 commits into from
Jan 8, 2024

Commits on Jan 6, 2024

  1. Fix branches to loops in IRBuilder 

    Since branches to loops go to the beginnings of the loops, they should values
matching the input types for the loops (which are always none because we don't
support loop input types). IRBuilder was previously using the output types of
loops to determine what values the branches should carry, which was incorrect.
Fix it.
    @tlively
    tlively committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    12e0d88 View commit details
    Browse the repository at this point in the history

  2. Fix incorrect wat in tests 

    The new wat parser is much more strict than the legacy wat parser; the latter
accepts all sorts of things that the spec does not allow. To ease an eventual
transition to using the new wat parser by default, update the tests to use the
standard text format in many places where they previously did not. We do not yet
have a way to prevent new errors from being introduced into the test suite, but
at least there will now be many fewer errors when it comes time to make the
switch.
    @tlively
    tlively committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    ded8529 View commit details
    Browse the repository at this point in the history