Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify method pairs with and without Type param #6184

Merged
merged 6 commits into from
Dec 21, 2023

Commits on Dec 19, 2023

  1. Unify methods pairs with and without Type param

    As suggested in
    WebAssembly#6181 (comment),
    using `std::optional<Type>`, this unifies two different versions of
    `make***`, for  block-like structures (`block`, `if`, `loop`, `try`, and
    `try_table`) with and without a type parameter.
    
    This also allows unifying of `finalize` methods, with and without a
    type. This also sets `breakability` argument of `Block::finalize` to
    `Unknown` so we can only have one `Block::finalize` that handles all
    cases.
    
    This also adds an optional `std::optional<Type> type` parameter to
    `blockify`, `blockifyWithName`, and `makeSequence` functions in
    `wasm-builder.h`.
    aheejin committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    38e0cae View commit details
    Browse the repository at this point in the history
  2. clang-format

    aheejin committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    fbf0330 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Configuration menu
    Copy the full SHA
    00dc7f2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9114bbc View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. Configuration menu
    Copy the full SHA
    ef9cdf0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    11fdab1 View commit details
    Browse the repository at this point in the history