-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
J2CL: use a more future proof naming convention for once functions #6173
Conversation
@kripken renamed |
Co-authored-by: Alon Zakai <[email protected]>
Looks like that didn't work. From the error I'm not sure what's wrong. Unfortunately I don't have much experience with either windows or the However @tlively perhaps your knowledge of |
@kripken I added a workaround with a note PTAL. |
I don't have a fix for the Windows escaping off the top of my head. The first thing I would try is doubling up on the backslashes and if that doesn't work I would debug on a Windows box. This workaround lgtm, though. |
…ebAssembly#6173) Existing convention uses _@once@_ but we also use @ for class separation. It is cleaner&more future proof to use something other convention like _<once>_.
Existing convention uses
_@once@_
but we also use@
for class separation.It is cleaner&more future proof to use something other convention like
_<once>_
.